Skip to content

fix: resolve Keystone "Unsupported output format: undefined" crash #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bryzettler merged 1 commit into from
Mar 24, 2026
Merged

fix: resolve Keystone "Unsupported output format: undefined" crash #1026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ios/HeliumWallet.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -868,7 +868,7 @@
"$(inherited)",
"@executable_path/Frameworks",
);
MARKETING_VERSION = 2.15.0;
MARKETING_VERSION = 2.15.1;
ONLY_ACTIVE_ARCH = NO;
OTHER_LDFLAGS = (
"$(inherited)",
Expand Down Expand Up @@ -906,7 +906,7 @@
"$(inherited)",
"@executable_path/Frameworks",
);
MARKETING_VERSION = 2.15.0;
MARKETING_VERSION = 2.15.1;
OTHER_LDFLAGS = (
"$(inherited)",
"-ObjC",
Expand Down Expand Up @@ -1093,7 +1093,7 @@
"@executable_path/Frameworks",
"@executable_path/../../Frameworks",
);
MARKETING_VERSION = 2.15.0;
MARKETING_VERSION = 2.15.1;
MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
MTL_FAST_MATH = YES;
OTHER_SWIFT_FLAGS = "$(inherited) -D EXPO_CONFIGURATION_DEBUG";
Expand Down Expand Up @@ -1138,7 +1138,7 @@
"@executable_path/Frameworks",
"@executable_path/../../Frameworks",
);
MARKETING_VERSION = 2.15.0;
MARKETING_VERSION = 2.15.1;
MTL_FAST_MATH = YES;
OTHER_SWIFT_FLAGS = "$(inherited) -D EXPO_CONFIGURATION_RELEASE";
PRODUCT_BUNDLE_IDENTIFIER = com.helium.wallet.app.OneSignalNotificationServiceExtension;
Expand Down Expand Up @@ -1186,7 +1186,7 @@
"@executable_path/Frameworks",
"@executable_path/../../Frameworks",
);
MARKETING_VERSION = 2.15.0;
MARKETING_VERSION = 2.15.1;
MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
MTL_FAST_MATH = YES;
OTHER_SWIFT_FLAGS = "$(inherited) -D EXPO_CONFIGURATION_DEBUG";
Expand Down Expand Up @@ -1235,7 +1235,7 @@
"@executable_path/Frameworks",
"@executable_path/../../Frameworks",
);
MARKETING_VERSION = 2.15.0;
MARKETING_VERSION = 2.15.1;
MTL_FAST_MATH = YES;
OTHER_SWIFT_FLAGS = "$(inherited) -D EXPO_CONFIGURATION_RELEASE";
PRODUCT_BUNDLE_IDENTIFIER = com.helium.wallet.app.HeliumWalletWidget;
Expand Down
9 changes: 5 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "helium-wallet",
"version": "2.15.0",
"version": "2.15.1",
"private": true,
"scripts": {
"eas-build-post-install": "./scripts/eas-build-setup.sh",
Expand Down Expand Up @@ -68,7 +68,7 @@
"@helium/voter-stake-registry-sdk": "0.11.4",
"@helium/wallet-link": "^5.0.4",
"@jup-ag/api": "6.0.6",
"@keystonehq/keystone-sdk": "0.11.6",
"@keystonehq/keystone-sdk": "0.11.7",
"@ledgerhq/hw-app-solana": "7.5.2",
"@ledgerhq/react-native-hid": "6.32.9",
"@ledgerhq/react-native-hw-transport-ble": "6.35.2",
Expand Down Expand Up @@ -269,7 +269,8 @@
"@helium/voter-stake-registry-hooks": "0.11.4",
"@helium/voter-stake-registry-sdk": "0.11.4",
"@helium/modular-governance-hooks": "0.1.5",
"@helium/onboarding": "^5.0.4"
"@helium/onboarding": "^5.0.4",
"@keystonehq/bc-ur-registry": "0.7.1"
},
"packageManager": "yarn@4.9.2"
}
}
4 changes: 1 addition & 3 deletions src/features/keystone/KeystoneModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,9 @@ const KeystoneModal = forwardRef(
setSolSignRequest({
requestId,
signData: transaction.toString('hex'),
dataType: KeystoneSolanaSDK.DataType.Message,
dataType: KeystoneSolanaSDK.DataType.Transaction,
path: currentAccount?.derivationPath || '',
xfp: currentAccount?.keystoneDevice?.masterFingerprint || '',
chainId: 1,
origin: 'Helium',
})
}
Expand All @@ -79,7 +78,6 @@ const KeystoneModal = forwardRef(
dataType: KeystoneSolanaSDK.DataType.Message,
path: currentAccount?.derivationPath || '',
xfp: currentAccount?.keystoneDevice?.masterFingerprint as string,
chainId: 1,
origin: 'Helium',
})
}
Expand Down
1 change: 0 additions & 1 deletion src/features/keystone/types/keystoneSolanaTxType.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,5 @@ export type KeystoneSolSignRequest = {
dataType: number
path: string
xfp: string
chainId: number
origin: string
}
34 changes: 6 additions & 28 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3789,29 +3789,7 @@ __metadata:
languageName: node
linkType: hard

"@keystonehq/bc-ur-registry@npm:^0.6.4":
version: 0.6.4
resolution: "@keystonehq/bc-ur-registry@npm:0.6.4"
dependencies:
"@ngraveio/bc-ur": "npm:^1.1.5"
bs58check: "npm:^2.1.2"
tslib: "npm:^2.3.0"
checksum: 10/d4cdbefc14f3305543340d509564e1a795eb458327d46aad8665927999150df7e282939dcb714b81fea386061019e3b9f41eedbbb09a59d404355711c33159b2
languageName: node
linkType: hard

"@keystonehq/bc-ur-registry@npm:^0.7.0":
version: 0.7.0
resolution: "@keystonehq/bc-ur-registry@npm:0.7.0"
dependencies:
"@ngraveio/bc-ur": "npm:^1.1.5"
bs58check: "npm:^2.1.2"
tslib: "npm:^2.3.0"
checksum: 10/44bb60d0e8471ec3148fab47bc3484406ea43b378c4e5bfbadc8978ed898ed387ad5d1c4f6b2983dced8ead4c26414e28a3b80c45364b6d066e0050a910e89d4
languageName: node
linkType: hard

"@keystonehq/bc-ur-registry@npm:^0.7.1":
"@keystonehq/bc-ur-registry@npm:0.7.1":
version: 0.7.1
resolution: "@keystonehq/bc-ur-registry@npm:0.7.1"
dependencies:
Expand All @@ -3822,9 +3800,9 @@ __metadata:
languageName: node
linkType: hard

"@keystonehq/keystone-sdk@npm:0.11.6":
version: 0.11.6
resolution: "@keystonehq/keystone-sdk@npm:0.11.6"
"@keystonehq/keystone-sdk@npm:0.11.7":
version: 0.11.7
resolution: "@keystonehq/keystone-sdk@npm:0.11.7"
dependencies:
"@bufbuild/protobuf": "npm:^1.2.0"
"@keystonehq/bc-ur-registry": "npm:^0.7.1"
Expand All @@ -3851,7 +3829,7 @@ __metadata:
pako: "npm:^2.1.0"
ripple-binary-codec: "npm:^1.4.3"
uuid: "npm:^9.0.0"
checksum: 10/8550a3b03140de40025d0aeaccf8323577cdcb9dea7244f26521cb69375431aed18b00d5c0680ce769a85a3a2911ce90d126b9a7531fcc5571a5b9b0d9d2325c
checksum: 10/4dde87196a7f69df58414c2f3804383c84e9ad9f2883326f4613a3b6a07a360d361a06d936c2cd9f70d6eaf2c6e1cd1e2253ca5faf4dae485d5cd144e34e6f3b
languageName: node
linkType: hard

Expand Down Expand Up @@ -12676,7 +12654,7 @@ __metadata:
"@helium/voter-stake-registry-sdk": "npm:0.11.4"
"@helium/wallet-link": "npm:^5.0.4"
"@jup-ag/api": "npm:6.0.6"
"@keystonehq/keystone-sdk": "npm:0.11.6"
"@keystonehq/keystone-sdk": "npm:0.11.7"
"@ledgerhq/hw-app-solana": "npm:7.5.2"
"@ledgerhq/hw-transport-mocker": "npm:6.29.8"
"@ledgerhq/react-native-hid": "npm:6.32.9"
Expand Down
Loading