fix: resolve Keystone QR scan button doing nothing#1027
Merged
bryzettler merged 2 commits intomainfrom Mar 24, 2026
Merged
Conversation
ConnectKeystoneStartScreen navigated to ScanQrCode at the root stack level, but the Add New Account screen is a transparentModal — so the scanner rendered behind the modal. Navigate to KeystoneNavigator within AddNewAccountNavigator instead, matching the Ledger flow pattern.
bryzettler
requested review from
a team,
Perronef5,
allenan and
tyler-whitman
and removed request for
a team,
Perronef5,
allenan and
tyler-whitman
Consolidate duplicated KeystoneStackParamList into a shared keystoneNavigatorTypes.ts (matching Ledger pattern). Type the createStackNavigator call. Fix eslint import/order violations.
ChewingGlass
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConnectKeystoneStartScreen navigated to ScanQrCode at the root stack level, but the Add New Account screen is a transparentModal — so the scanner rendered behind the modal. Navigate to KeystoneNavigator within AddNewAccountNavigator instead, matching the Ledger flow pattern.