fix: resolve Keystone QR scan button doing nothing#1028
Merged
bryzettler merged 1 commit intomainfrom Mar 24, 2026
Merged
Conversation
The button did nothing due to two issues: 1. Navigation targeted the root stack, rendering the scanner behind the modal. Fixed by navigating to KeystoneNavigator within the AddNewAccountNavigator stack. 2. The useCamera hook's async permission check caused a race condition where hasPermission was always false on first tap, and the fallback BottomSheetModal failed silently inside a ScrollView. Removed the redundant permission gate entirely — DynamicQrScanner already handles all camera permission states on mount.
bryzettler
requested review from
Perronef5,
allenan and
tyler-whitman
and removed request for
a team,
Perronef5,
allenan and
tyler-whitman
ChewingGlass
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The button did nothing due to two issues:
Removed the redundant permission gate entirely — DynamicQrScanner already handles all camera permission states on mount.