Skip to content

docs: improve last_picker docs #10843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: improve last_picker docs #10843

wants to merge 1 commit into from

Conversation

markstos
Copy link
Contributor

  • Consistency: Before it was described as "fuzzy" in place but not another.
    All the pickers seem to be fuzzy pickers, so remove that word for consistency.

  • Clarity: Document how it's different from other pickers and adds value
    by restoring the selected entry when it opens-- a valuable feature to make
    more discoverable.

@markstos
docs: improve last_picker docs
3db8ca6 
- Consistency: Before it was described as "fuzzy" in place but not another.
  All the pickers seem to be fuzzy pickers, so remove that word for consistency.

- Clarity: Document how it's different from other pickers and adds value
  by restoring the selected entry when it opens-- a valuable feature to make
  more discoverable.
the-mikedavis
the-mikedavis reviewed Jun 3, 2024
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's preserving more than the last selected entry: also the scroll of the options and the cache of highlights for the preview. It's more like "reopening" / "unclosing" the last picker

@the-mikedavis the-mikedavis added the A-documentation Area: Documentation improvements label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis left review comments

@TornaxO7 TornaxO7 TornaxO7 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
A-documentation Area: Documentation improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markstos @the-mikedavis @TornaxO7