Skip to content

Use configured LSP name wherever possible in --health #13573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

superseed
Copy link
Contributor

I recently got confused when I checked --health rust and saw this:

Configured language servers:
  ✓ rustup: /usr/bin/rustup

It's actually due to having the following in my languages configuration (because I wanted to try out the range formatting features):

[language-server.rust-analyzer]
command = "rustup"
args = ["run", "nightly", "rust-analyzer"]

So --health actually prints the command of the LSP rather than the configured name. I believe it would make more sense to print the name along with the path, so in my case:

Configured language servers:
  ✓ rust-analyzer: /usr/bin/rustup

I also changed the --health "all languages" to have the same behavior and the DAP/formatter output style to match the LSP style (newline, checkmark), for example:

> helix --health swift
Configured language servers:
  ✘ sourcekit-lsp: 'sourcekit-lsp' not found in $PATH
Configured debug adapter: None
Configured formatter:
  ✘ 'swift-format' not found in $PATH
Tree-sitter parser: ✓
Highlight queries: ✓
Textobject queries: ✓
Indent queries: ✘

Also match the DAP/Formatter output style to the LSP style
@the-mikedavis the-mikedavis merged commit 76029e5 into helix-editor:master May 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants