-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
make command(inspired from vim) #14328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
change visibility of parsing functions change into_iter function to IntoIterator trait
plus impl Index traits for list
instead of typing them in all the time
I don't know how, but it seems i've forgot to explain how this feature even functions [editor.make-cmds."/home/user/full/path/to/project"] then if you have the project open in helix you can type in :make or :mk to run the command, it then uses regex to parse the data and you get a picker over the errors(opened by pressing space-m) |
Dont think this is finished, its still missing things like displaying inline text in the same way diagnostics do(and also make it possible to turn it off in the config), or probably a few additional regex'es to make it more useful for more people, or probably some tests, but i won't have the time now to implement these now, so figured might as well send the pull request.
I still think its a good start for a feature i've seen was requested by people(and myself).
From testing for a couple days with mainly gcc/clang output it works great.
Here are some suggestions for future development if this ever gets integrated into the codebase, that i didnt have time to implement:
The fact you need to either retype the command(or press the up-arrow a few times) all the time is kind of annoying, maybe it would be nice to specify some commands in the config, and then have a picker over them.
It would be nice to somehow see the full output of the command.
It would be nice to see the returned code by the command.