refactor!: change default windows shell to powershell#14358
refactor!: change default windows shell to powershell#14358RoloEdits wants to merge 1 commit intohelix-editor:masterfrom
powershell#14358Conversation
|
How significant is the difference in latency between cmd and powershell? I'm generally okay with this change |
|
From what I have seen personally, as well as what other people seem to experience, its an order of magnitude difference. Say 20ms for CMD and 200ms for powershell. Powershell Core should in theory be faster? Specially with newer runtimes, which employs a dynamic PGO, so the initial code generation is built to a "tier 0" level and then it can optimize as its running, but allows for faster startup times. This will depend on the users environment a lot, though, so hard to say in practice, but definitely slower than cmd, which is written in C. And also this PR is to make the Powershell Windows one the default, This PR is really a tradeoff: its slower, which depending on what operations the user is doing could be noticeable, but also seems to be free of some cmd eccentricities. I was hoping to get some more feedback on this before it was merged, from people who might switch over to test it out, but as it stands now, cant be sure of the fallout. From #14229:
and
As a general experience from switching. |
This follows discussion from #14229 (comment). This follows a generally understood position that
cmdcan be finicky, and even buggy, but wont be fixed due to compatibility issues:BREAKING: If user previously relied on specific
cmdfeatures or behavior, they will need to update their config.