Add support for KittyCAD lang (KCL) #14542
Merged
+77
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
languages.toml
Outdated
|
|
||
| [[grammer]] | ||
| name = "kcl" | ||
| source = { git = "https://github.com/KittyCAD/tree-sitter-kcl", rev = "1f9e40020b1bb76b31a7144b994bec1a559dc735"} |
There was a problem hiding this comment.
It looks like this grammar repository doesn't have a license - could you suggest adding one upstream and update the rev here once one is included? Grammar repositories need to have licenses for the sake of packaging them
There was a problem hiding this comment.
Note, they do specify a license in their Cargo.toml, pyproject.toml, and tree-sitter.json, only a copy isn't included. PR open to add the copy KittyCAD/tree-sitter-kcl#18
There was a problem hiding this comment.
New rev has a LICENSE. Moving language server definition to the top of the file to match the existing pattern
the-mikedavis
approved these changes
Oct 14, 2025
|
Thanks Mike! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for KCL from Zoo.dev
See https://zoo.dev/docs/kcl-book/intro.html for more info
Credit to @adamchalmers for his config