Skip to content

Conversation

m4rch3n1ng
Copy link
Contributor

notable changes include:

additionally i also added (shebang) as an @comment.

@m4rch3n1ng m4rch3n1ng force-pushed the update-tree-sitter-rust branch from 7034469 to 97a7a26 Compare October 6, 2025 17:15
@m4rch3n1ng m4rch3n1ng changed the title languages.toml: update tree sitter rust languages.toml: update tree-sitter-rust to latest Oct 6, 2025
(constrained_type_parameter
left: (type_identifier) @type.parameter)
(optional_type_parameter
(type_parameter
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be (type_parameters (type_parameter name: (type_identifier) @type.parameter)) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be, but i don't really see the benefit of that. a (type_parameter can currently only appear inside of a (type_parameters, so it doesn't matter, but why unnecessarily restrict that?

additionally, previously the (optional_type_parameter was also only queried like that and it wasn't a (type_parameters (optional_type_parameter ....

@the-mikedavis the-mikedavis merged commit c664b84 into helix-editor:master Oct 14, 2025
7 checks passed
@m4rch3n1ng m4rch3n1ng deleted the update-tree-sitter-rust branch October 14, 2025 22:58
@mi2ebi
Copy link
Contributor

mi2ebi commented Oct 15, 2025

2025-10-15T10:56:31.282 helix_core::syntax [ERROR] Failed to compile highlights for 'rust': invalid node type "type_parameter"
  --> 82:2
    |
 82 | (type_parameter
    |  ^^^^^^^^^^^^^^
 83 |   name: (type_identifier) @type.parameter)
    |

@m4rch3n1ng
Copy link
Contributor Author

does hx --grammar fetch and hx --grammar build fix that? to me it looks like your grammars are out-of-date while your queries are up-to-date.

@mi2ebi
Copy link
Contributor

mi2ebi commented Oct 15, 2025

aha yep that worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants