Keep LSP completions active when typing server-trigger characters #14556
+57
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tailwind’s language server advertises -, /, :, etc. as completion triggers. Helix treated those punctuation characters as “not word characters”, cleared the current completion popup, and asked the server for a fresh list. That made Tailwind’s suggestions reset on every -. Changes - On each typed character, before clearing the popup for a non-word char, look at the active LSP providers and see whether any of them list the character in completionProvider.triggerCharacters. - If so, keep the existing menu and just rescore items instead of removing the list. - Fall back to the old behaviour for punctuation that no connected server actually cares about. **NOTE:** AI wrote this code but I did test it manually and check the code which looks like to me makes sense (I'm new to the codebase though) fixes: helix-editor#12541
|
Though this fixes the dash, there are still some issues with “:” and maybe slash. I’ll look into a bit more |
After looking into how [neovim] does completion I've changed things
around a bit.
- pass the triggering char into the completion refresher and send it as
CompletionTriggerKind::TRIGGER_CHARACTER
- fall back to TriggerForIncomplete only when the original list was
partial
[neovim]: https://github.com/neovim/neovim/blob/d7472c061759aa56c43c36bdb5ce463e3ee8521d/runtime/lua/vim/lsp/completion.lua#L315
|
Okay this should work now! I tried it with "-", ":", and "/". Still could use some robustness though. Seems to be I can get it not work sometimes if I input certain strings but it doesn't crash and is better than the previous version. Also check the typescript lsp to see if things were still working and they seem to be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tailwind’s language server advertises -, /, :, etc. as completion triggers. Helix treated those punctuation characters as “not word characters”, cleared the current completion popup, and asked the server for a fresh list. That made Tailwind’s suggestions reset on every -.
Changes
NOTE: AI wrote this code but I did test it manually and check the code which looks like to me makes sense (I'm new to the codebase though)
fixes: #12541