don't set the row position to the empty last line with the + cli arg
#14590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this matches the behaviour of goto last line.
m4rch3n1ng
changed the title
+ cli arg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slight followup to #14571, as the behaviour was already there previously but is more noticeable with that pr.
helix, like most editors, always keeps an empty line around at the end. currently doing
hx + <file>moves the cursor to the very last line, the one that is empty and doesn't even have a line number (just a ~). this is annoying, as there is never anything on the last line and you always have tokone extra time to get to the content. with this pr it will no longer jump to the very last line, if that is empty.this now also matches the behaviour of goto last line and of doing
:<number>, where<number>is higher than the number of lines in the file.