Detach spawned LSP client from helix #14601
Open
+25
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the same as neovim/neovim#18477 This prevents LSP clients from manipulating the TTY of the parent process (helix)
RoloEdits
reviewed
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the same as neovim/neovim#18477. Neovim does not spawn the LSP process themself but use libuv. The relevant code for spawning the process can be found here (unix) and here (windows). What I didn't include is the
CREATE_SUSPENDEDflag for windows. Since I was not sure what its purpose is, I didn't include it.Fixes #2578