fix: stale "nothing selected" and "no selections remaining" errors persisting after successful regex selection #15051
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
approved these changes
Jan 6, 2026
Member
the-mikedavis
left a comment
the-mikedavis
left a comment
There was a problem hiding this comment.
Nice, I've seen these but when I tried to fix it I couldn't figure out when/why it happens. Yep, we should only be setting these errors on Validate
rcharre
pushed a commit
to rcharre/helix
that referenced
this pull request
Jan 7, 2026
…rsisting after successful regex selection (helix-editor#15051)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny fix for "nothing selected" and "no selections remaining" errors generated during typing being incorrectly persisted to the status line.
If any intermediate state of the regex (while typing) yields no matches, an error is set in the editor status line (but not visible). And successful match does not explicitly clear this error, so it remains there (in the editor status line) even after the user completes a valid regex and confirms the selection. It's probably fine to only add this error after confirm?
An alternative fix would be to explicitly clear this error on a successful match.