Skip to content

Conversation

@BrownNPC
Copy link

@BrownNPC BrownNPC commented Jan 4, 2026

BrownNPC and others added 5 commits January 5, 2026 03:07
Co-authored-by: Kristoffer Plagborg Bak Sørensen <[email protected]>
Co-authored-by: Kristoffer Plagborg Bak Sørensen <[email protected]>
Co-authored-by: Kristoffer Plagborg Bak Sørensen <[email protected]>
@BrownNPC
Copy link
Author

BrownNPC commented Jan 6, 2026

@kpbaks Anything else that needs fixing?

@kpbaks
Copy link
Contributor

kpbaks commented Jan 6, 2026

@kpbaks Anything else that needs fixing?

I will have a look at it again in the afternoon 🙂


[[language]]
name = "umka"
scope = "source.umka"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
scope = "source.umka"
scope = "source.umka"
injection-regex = "umka"

@kpbaks
Copy link
Contributor

kpbaks commented Jan 6, 2026

Do you know if the language provides a formatting or lsp program?

@kpbaks
Copy link
Contributor

kpbaks commented Jan 6, 2026

While we only require highlights.scm queries for a new language it would be great to have as many of the other queries we use supported as well. I do not know anything about the language at all, but played a bit around with adding rainbows.scm queries to it.

[
  (literal)
  (builtinCallFmt)
  (qualIdent)
  (constDecl)
  (rcvSignature)
  (parameterList)
  (switchStmtDisambiguated)
  (exprSwitchStmt)
  (builtinCallBasic)
  (fullVarDecl)
  (typeOf)
  (block)
  (functionCall)
  (builtinCallMake)
  (returnType)
  (import)
] @rainbow.scope

[
  "{" "}"
  "(" ")"
  "[" "]"
] @rainbow.bracket

I do not think I have covered all the language constructs. If you put it in runtime/queries/umka/rainbows.scm and do HELIX_RUNTIME=$PWD/runtime hx file.um you can see it in effect. Could you go over it and add remaining patterns missing? I have not covered enums and map/index literals, and probably some I am not aware about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants