fix(queries:properties): proper numeric values#15281
Open
Rudxain wants to merge 1 commit intohelix-editor:masterfrom
Open
fix(queries:properties): proper numeric values#15281Rudxain wants to merge 1 commit intohelix-editor:masterfrom
Rudxain wants to merge 1 commit intohelix-editor:masterfrom
Conversation
32402e5 to
6d6f1f0
Compare
6d6f1f0 to
a5365ae
Compare
a5365ae to
3bb61d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
floatandintegerso thatintegerhas a chance to match. Previously, onlyfloatcould match a value, because of its order and broadnessfloats (yes,-.1is valid!)floatsUnresolved questions:
\d+.be consideredfloat?infinitybe consideredfloat? if so, case-sensitive?Important
The Java spec says "yes" to the first two, but that would make the regexes more complex, and I haven't fully tested it
Questions that I've answered to myself:
NaNbe afloat? absolutely no, who would need that?follow-up of #13874