Fix mm inconsistency with some treesitter grammars#15288
Open
axelcool1234 wants to merge 1 commit intohelix-editor:masterfrom
Open
Fix mm inconsistency with some treesitter grammars#15288axelcool1234 wants to merge 1 commit intohelix-editor:masterfrom
mm inconsistency with some treesitter grammars#15288axelcool1234 wants to merge 1 commit intohelix-editor:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following fixes #15287. The change is to simply make the
endparameter ofdescendent_for_byte_rangebepos + 1instead ofpos. I believe the culprit commit that lead to this bug was #10613 (before this change it was alsopos + 1) but this was a major improvement on how pair matching was implemented so the bug may have existed before this as well.I am unsure if this leads to any regressions but I doubt it.