Improve docs and logging for lsp root selection#15289
Open
RmStorm wants to merge 1 commit intohelix-editor:masterfrom
Open
Improve docs and logging for lsp root selection#15289RmStorm wants to merge 1 commit intohelix-editor:masterfrom
RmStorm wants to merge 1 commit intohelix-editor:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See this issue #14649 and in particular @pascalkuthe's comment there. I have tried to keep my wording close to his.
In addition I have looked at the source code and added two log statements. A warning when an lsp is not allowed to start due to it's
required-root-patternsand an info log when an lsp root has been selected and helix attempts to start it up. I think this is really valuable information that will make debugging these types of issues much easier!