feat(cli): support #section syntax when opening files at sections via cli or typed command#15686
Open
sukidhar wants to merge 3 commits intohelix-editor:masterfrom
Open
feat(cli): support #section syntax when opening files at sections via cli or typed command#15686sukidhar wants to merge 3 commits intohelix-editor:masterfrom
sukidhar wants to merge 3 commits intohelix-editor:masterfrom
Conversation
Author
|
I have updated the tests, I ran |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15680
Instead of using just positions, updated the structure to use position as part of
FileTargetstruct. It adds support for opening files by section. For now, it opens at sections as the issue suggested. I have tested this withREADME.mdand also withCargo.toml. As long as theTagKind::Sectionis supported by the language of file, it should work on both the cli as well as commands from the editor. As of now, it takesSectionprecedence over the usual positioning. I am not sure if something like a mix of both is required.Examples
I am contributing for the very first time on this repository. happy to address any changes needed. Thanks!