fix: lsp: correctly clear workspace diagnostics on LSP(s) stop or restart - #16071
Open
poliorcetics wants to merge 3 commits into
Conversation
matoous
reviewed
Jul 20, 2026
poliorcetics
force-pushed
the
ab/fix-lsp-stop-language-servers-when-the-last-document-using-them-i/pzpsslzwylxm
branch
from
July 20, 2026 21:40
f6ac138 to
f038595
Compare
…tart Before this commit, using `:lsp-stop` or `:lsp-start` would not clear existing workspace diagnostics.
poliorcetics
force-pushed
the
ab/fix-lsp-stop-language-servers-when-the-last-document-using-them-i/pzpsslzwylxm
branch
from
July 25, 2026 09:30
f038595 to
5fff8d1
Compare
rohel01
suggested changes
Aug 17, 2026
poliorcetics
force-pushed
the
ab/fix-lsp-stop-language-servers-when-the-last-document-using-them-i/pzpsslzwylxm
branch
from
August 17, 2026 20:15
54faf82 to
01083f1
Compare
This avoids duplicating the logic of argument checking and LSP selection
poliorcetics
force-pushed
the
ab/fix-lsp-stop-language-servers-when-the-last-document-using-them-i/pzpsslzwylxm
branch
from
August 18, 2026 11:47
01083f1 to
fc705f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also stops language servers when the last document using them is closed.
As in #16070, workspace diagnostics would accumulate infinitely when doing
:lsp-restartand not disappear when doing:lsp-stopCloses #16076