Switch default comment to # #6470
Conversation
Having # as comment is far more common in non-support files like random configuration files as compared to //, so it will be using the correct comment at a higher chance.
|
There is #3799 |
|
Thanks for linking me to that, I think that is good, but this does a different thing, it sets the default comment character to |
|
Ah whoops, I hadn't looked at the changes 😅 |
the-mikedavis
added
S-waiting-on-review
|
dependes. I'm perfectly fine with // for c . |
|
We have no issues with c and c++ and rust or the likes with But instead, tons of random configuration that we do not support uses |
| @@ -60,7 +60,7 @@ fn find_line_comment( | |||
| pub fn toggle_line_comments(doc: &Rope, selection: &Selection, token: Option<&str>) -> Transaction { | |||
| let text = doc.slice(..); | |||
|
|
|||
| let token = token.unwrap_or("//"); | |||
| let token = token.unwrap_or("#"); | |||
There was a problem hiding this comment.
This feels like it should be configurable. And then change the default in the configuration.
|
If anything is, then |
|
Superceded by #12080 |
Having # as comment is far more common in non-support files like random configuration files as compared to //, so it will be using the correct comment at a higher chance.