Skip to content

[3209] feat(lsp): range formatting #9156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matoous
Copy link
Contributor

@matoous matoous commented Dec 24, 2023

Add basic range formatting capabilities when multiple selection are present.

This is a naive implementation that doesn't handle overlapping ranges. This can be implemented in follow-up PR, for example using https://github.com/microsoft/vscode/blob/d1e7a941945ce2c81e04cb01b0460e7e952d4916/src/vs/editor/contrib/format/browser/format.ts#L128 as a reference.

Spec: Document Range Formatting Request

Related: #3209 (comment)

@matoous matoous marked this pull request as draft December 24, 2023 00:16
@matoous matoous force-pushed the 3209-range-formatting branch from 5449325 to 8e9a5d3 Compare December 24, 2023 00:16
@matoous matoous force-pushed the 3209-range-formatting branch 3 times, most recently from e9937d6 to 1ae3cb9 Compare February 1, 2024 22:55
@kirawi kirawi added the A-language-server Area: Language server client label Apr 22, 2024
@matoous matoous force-pushed the 3209-range-formatting branch from 1ae3cb9 to 29ea9d8 Compare July 17, 2024 19:09
Add basic range formatting capabilities when multiple selection
are present.

Related: helix-editor#3209 (comment)
@matoous matoous force-pushed the 3209-range-formatting branch from 29ea9d8 to 62f6bb3 Compare July 17, 2024 20:01
@matoous matoous marked this pull request as ready for review July 17, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-server Area: Language server client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants