Pattern parsing fixes related to escape handling#87
Open
alexrutar wants to merge 3 commits intohelix-editor:masterfrom
Open
Pattern parsing fixes related to escape handling#87alexrutar wants to merge 3 commits intohelix-editor:masterfrom
alexrutar wants to merge 3 commits intohelix-editor:masterfrom
Conversation
This also fixes an unrelated bug when parsing needles which contain non-ASCI Unicode.
alexrutar
force-pushed
the
parsing-fixes
branch
from
134fa48 to
27849c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements three parsing fixes.
\inMultiPattern::reparse#66: we now check for a trailing backslash\when running 'reparse' to correctly force a complete rescore (rather than just an update).is_whitespacechecks (same behaviour as with the Unicode handling).\push that had to be deferred until the beginning of the subsequent loop. This was causing invalid handling of e.g.foö\ bar.I've also added quite a few tests to check that the parsing code behaves as expected.
This was previously #67 but now slightly better implementation and I'm making a new PR because the other one is filled with unnecessary details.