Skip to content

Fix Runstop Button and Homing Functionality#5

Merged
hello-vinitha merged 5 commits into
mainfrom
bugfix/runstop
Jun 15, 2026
Merged

Fix Runstop Button and Homing Functionality#5
hello-vinitha merged 5 commits into
mainfrom
bugfix/runstop

Conversation

@hello-vinitha

@hello-vinitha hello-vinitha commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR fixes the runstop button functionality and updates the subscriptions for the is_homed and is_runstopped state to use the /joint_states_diagnostics topic from hello-robot/stretch4_ros2#14

Testing procedure for Homing

To test the homing sequence start with a freshly booted robot or reboot the feetechs by running stretch_feetech_reboot. You will have to kill the SBS by running stretch_body_server --kill first. Launch the interface: ./launch_interface.sh

  • You should see the calibration required alert at the top of the screen:
image - [ ] Click `start calibration` and the robot will start homing. - [ ] When complete you should see an alert that says `calibration complete` and the alert should disappear. - [ ] Refresh the page to check that the homed state is maintained

Testing procedure for the Runstop

Launch the interface: ./launch_interface.sh. The runstop button is in the bottom right corner of the screen. Press it to enable the run stop and press it again to disable.

  • Verify the text changes to "Run" and the button pulses when the runstop is enabled.
  • Verify the test changes to "Stop" and does not pulse when the runstop is disabled.
  • Press the runstop button on the robot and verify the state is updated on the interface.

Before opening a pull request

From the top-level of this repository, run:

  • pre-commit run --all-files

To merge

  • Squash & Merge

@hello-vinitha hello-vinitha changed the title [WIP] Added runstop button functionality Fix Runstop Button and Homing Functionality Jun 11, 2026
@hello-vinitha hello-vinitha self-assigned this Jun 11, 2026
@hello-vinitha
hello-vinitha requested a review from hello-garv June 11, 2026 19:14

@hello-garv hello-garv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I will continue working on the stretch4_ros2 PR to improve the homing signal.

@hello-garv

Copy link
Copy Markdown
Contributor

The calibration notification sticks around until the gripper finishes homing. Works as expected with the latest stretch4_ros2 updates 🥳

@hello-vinitha

hello-vinitha commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator Author

Great! I will merge this PR when hello-robot/stretch4_ros2#14 gets merged.

@hello-vinitha
hello-vinitha merged commit 3e180af into main Jun 15, 2026
1 check passed
@hello-vinitha
hello-vinitha deleted the bugfix/runstop branch June 15, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants