Fix Runstop Button and Homing Functionality#5
Merged
Conversation
hello-garv
approved these changes
Jun 12, 2026
hello-garv
left a comment
Contributor
There was a problem hiding this comment.
LGTM, I will continue working on the stretch4_ros2 PR to improve the homing signal.
Contributor
|
The calibration notification sticks around until the gripper finishes homing. Works as expected with the latest stretch4_ros2 updates 🥳 |
Collaborator
Author
|
Great! I will merge this PR when hello-robot/stretch4_ros2#14 gets merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the runstop button functionality and updates the subscriptions for the
is_homedandis_runstoppedstate to use the/joint_states_diagnosticstopic from hello-robot/stretch4_ros2#14Testing procedure for Homing
To test the homing sequence start with a freshly booted robot or reboot the feetechs by running
stretch_feetech_reboot. You will have to kill the SBS by runningstretch_body_server --killfirst. Launch the interface:./launch_interface.shTesting procedure for the Runstop
Launch the interface:
./launch_interface.sh. The runstop button is in the bottom right corner of the screen. Press it to enable the run stop and press it again to disable.Before opening a pull request
From the top-level of this repository, run:
pre-commit run --all-filesTo merge
Squash & Merge