Multirobot setup v2#119
Closed
tenny-yinyijun wants to merge 4 commits into
Closed
Conversation
Co-authored-by: Janna Lin <jnl77@cornell.edu>
Contributor
|
Hey @tenny-yinyijun, the changes in this revision look great! You can actually make these changes on top of your previous PR, so you don't have to open a new PR per revision. Then, Github will keep track of our revisions and design discussions in one place. To add these changes to your previous PR, copy them over onto your fork, tenny-yinyijun/stretch_ros, on the noetic branch. When you commit and push them, the previous PR will automatically update. |
Author
|
Thanks @hello-binit! I just copied the this fork onto noetic |
Contributor
|
Thanks, closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Thank you so much for the detailed feedback from the last pr, it has been very helpful! This version includes all changes except the remapping, for future changes if you think it's easier we'll be happy to meet over zoom! Thanks in advance:)