feat: add --wait flag to helm uninstall #721
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, the
helm uninstallcommand does not use a--waitflag, unlike thehelm installandhelm upgradecommands. This can lead to issues, specifically withct install --upgrade, where certain resources (in our case, namespaces other than the release namespace) have not yet been fully deleted from the kubernetes cluster, despite thehelm uninstallcommand having exited successfully. This is causing the subsequenthelm installto fail.By forcing
helm uninstallto wait, these race conditions should not be an issue.Special notes for your reviewer:
We considered using
helm-set-args '--wait'to achieve this, but thehelm testcommand does not recognize the--waitflag and therefore fails. A less clean but less heavy-handed approach could be to strip the--waitflag before runninghelm test.