Fix chart_schema.yaml import-values rule #725
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The existing rule for validating dependency import-values worked well for either of these two cases:
1. Importing exports
2. Importing child values into the parent
However, it failed on the following valid usecase:
Giving the following error:
This is because the Yamale is validating on a list of strings or a list of
import-value
, where a list containing both is also valid.This commit changes the rule to allow both methods to be in the
import-values
list.