-
Notifications
You must be signed in to change notification settings - Fork 183
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add HIP for running hooks in parallel
Signed-off-by: MichaelMorris <[email protected]>
- Loading branch information
1 parent
36ac1d9
commit 4edcbab
Showing
1 changed file
with
68 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
-- | ||
hip: 0020 | ||
title: "Enable Running Hooks in Parallel" | ||
authors: [ "Michael Morris <[email protected]>" ] | ||
created: "2024-06-06" | ||
type: "feature" | ||
status: "draft" | ||
--- | ||
|
||
## Abstract | ||
|
||
Helm hooks are currently executed serially. In many cases there will be no reason why they cannot be run in parallel. Running hooks in parallel can significantly improve install/upgrade times | ||
|
||
## Motivation | ||
|
||
Decrease install/upgrade times by executing hooks in parallel | ||
|
||
## Specification | ||
|
||
Add a new flag to the install, upgrade, rollback and uninstall commands to enable parallel behavior for hook execution. The flag will be of integer type and will allow the user to specify the maximum number of hooks that can be executed in parallel. | ||
|
||
The flag shall be optional. If not set or set to "0" or "1", hook execution shall be done serially. If set to a value greater than "1", hook execution shall be done in parallel, subject to not exceeding the given value in the number of hooks executed in parallel. | ||
|
||
Only hooks of the same weight shall be executed in parallel. | ||
|
||
## Rationale | ||
|
||
While it may be desirable to run hooks in parallel, particularly those of the same weight, doing so by default may cause issues for users depending on the existing serial behavior. Therefore it is proposed to keep the existing serial behavior by default and enable parallel behavior through the use of a flag. | ||
|
||
Making the flag an integer rather than boolean allows the user to possibility to restrict the number of parallel processes where resource constraints are a concern. | ||
|
||
Allowing hooks of different weights to be executed in parallel is probably not consistent with the documented behavior of lower weight hooks being executed before higher weighted hooks and, therefore only hooks of the same weight shall be executed in parallel | ||
|
||
## Backwards compatibility | ||
|
||
Proposed solution is fully backwards compatible with no changes in default behavior. | ||
|
||
## Security implications | ||
|
||
None | ||
|
||
## How to teach this | ||
|
||
Document in command line help and https://helm.sh/docs/topics/charts_hooks/. | ||
|
||
## Reference implementation | ||
|
||
PR submitted some time ago: https://github.com/helm/helm/pull/11804 | ||
May need to be updated depending on decisions taken on what is proposed here. | ||
|
||
## Rejected ideas | ||
|
||
Why certain ideas that were brought while discussing this HIP were not | ||
ultimately pursued. | ||
|
||
## Open issues | ||
|
||
|Issue |Proposal|Decision| | ||
|-----------------------------------------------------------------------------------------|--------|--------| | ||
|Should we allow hooks to be run in parallel |Yes | | | ||
|Should the default behaviour continue to be to execute in serial |Yes | | | ||
|Is there benefit in allowing the user limit the max number of hooks executing in parallel|Yes | | | ||
|Should only hooks of the same weight be executed in parallel |Yes | | | ||
|
||
|
||
## References | ||
|
||
There exists an older closed HIP on hook parallelism, but its focus was on test hooks: https://github.com/helm/community/pull/165 |