-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
H4HIP: Adding a HIP on charts v3 #381
Draft
mattfarina
wants to merge
1
commit into
helm:main
Choose a base branch
from
mattfarina:charts-v3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+77
−0
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
--- | ||
hip: 9999 | ||
title: "H4HIP: Charts v3 Enablement" | ||
authors: [ "Matt Farina <[email protected]>" ] | ||
created: "2025-01-09" | ||
type: "feature" | ||
status: "draft" | ||
--- | ||
|
||
## Abstract | ||
|
||
This HIP proposes the creation of charts v3, updating Helm to handle charts v2 and v3, and a | ||
timeline for the general availability of charts v3 that can happen after the release of Helm v4.0.0. | ||
|
||
## Motivation | ||
|
||
Many of the proposed changes for Helm v4 affect charts. Layering these onto existing charts will | ||
sometimes cause chart installation and upgrade to happen differently in Helm v3 and Helm v4, as | ||
both will need to live side by side for a time. It also means that testing of charts for v3 can produce | ||
a different result when installed with Helm v4. | ||
|
||
In addition to the affects of the changes, Helm v4 development has a fixed timeline and making | ||
changes to Helm in addition to reworking charts is not likely to fit within that fixed window. Enabling | ||
the development of charts v3 to happen as an experiment that becomes generally available after | ||
the release of Helm v4 provides more time to continue the work and get feedback. | ||
|
||
The goal is to provide adequate time to work on chart changes while doing it in a way that enables | ||
trust in existing charts to run as they were tested. | ||
|
||
## Rationale | ||
|
||
Charts v2 were created for Helm v3 and introduced minor changes. The code that handles the chart | ||
versions is the same with some checking to handle the differences. This handling ended up having | ||
numerous bugs that had to be worked out in patch releases. | ||
|
||
The chart changes being proposed for Helm v4 are more significant. Mixing those in alongside the | ||
current chart version handling will have trouble limiting bugs will enabling the changes and keeping | ||
existing charts functioning properly. | ||
|
||
The design specified here is meant to enable the current charts to work as expected while providing | ||
space for more radical changes. | ||
|
||
## Specification | ||
|
||
Describe the syntax and semantics of any new feature. | ||
|
||
|
||
|
||
## Backwards compatibility | ||
|
||
Describe potential impact and severity on pre-existing code. | ||
|
||
## Security implications | ||
|
||
How could a malicious user take advantage of this new feature? | ||
|
||
## How to teach this | ||
|
||
How to teach users, new and experienced, how to apply the HIP to their work. | ||
|
||
## Reference implementation | ||
|
||
Link to any existing implementation and details about its state, e.g. | ||
proof-of-concept. | ||
|
||
## Rejected ideas | ||
|
||
Why certain ideas that were brought while discussing this HIP were not | ||
ultimately pursued. | ||
|
||
## Open issues | ||
|
||
Any points that are still being decided/discussed. | ||
|
||
## References | ||
|
||
A collection of URLs or materials used as references through the HIP. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only problem, is we don't quite know what v3 would look like yet I think.
So we should aim to support both v2 and a future (or "placeholder") v3?