Skip to content

Conversation

@elwin013
Copy link

Add quoting (using | quote) for password in imagePullSecret helper and removing additional (artificial) quote
characters as those are added by quote func.

This change allows to use more complicated password with e.g. quotes, backslashes and other special characters.

Copy link
Contributor

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@github-actions
Copy link

This pull request has been marked as stale because it has been open for 90 days with no activity. This pull request will be automatically closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Nov 11, 2025
Add quoting (using `| quote`) for password in imagePullSecret helper and removing
additional (artifical) quote characters as those are added by `quote` func.

This change allows to use more complicated password with e.g. quotes, backslashes
and other special characters.

Signed-off-by: Kamil Banach <[email protected]>
@elwin013 elwin013 force-pushed the quote-password-in-imagePullSecret-helper branch from be5d212 to dab98b2 Compare December 9, 2025 20:04
@elwin013
Copy link
Author

elwin013 commented Dec 9, 2025

I've updated the new files with same changes (should be applied now to all files).

@TerryHowe wdyt? 🙂

@github-actions github-actions bot removed the Stale label Dec 10, 2025
Copy link
Contributor

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants