-
Notifications
You must be signed in to change notification settings - Fork 581
Translate topic section in italian language #1602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9a01804 to
a83b12f
Compare
|
hi @karenhchu , is there something wrong with the PR that I can correct? This is my first PR and I am scared of making some errors. Thank you |
|
@nfantoni thanks for surfacing this again and for your patience! I'll try my best to review this by EOW. Please ping me again if I don't get to it. |
|
@karenhchu don't worry. i absolutely don't want to rush you! Thank you very much for your reply! |
karenhchu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! There are a few pages that need to be updated but otherwise, it's in a great state. Please tag me when you've made the suggested changes and I'll take a look again.
|
Hi @karenhchu ! Thanks for the review! I think i solved every things. the plugin page was updated after my pr and is not aligned. I hope now is ok. Let me now if need other! |
karenhchu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We may need another approval since the PR is so large -- @scottrigby is this something you can take a look at?
I'm sorry. I promise the next ones will be smaller |
|
Hey apologies for missing this. I will review after the Helm 4 pre-release freeze in August ⏳ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a comprehensive Italian translation for the Helm website's topic section. The translation covers all major documentation areas including charts, architecture, advanced features, and various technical guides.
- Complete translation of the Italian localization file (
i18n/it.toml) with 223 entries - Translation of all topic documentation files from English to Italian
- Addition of Italian language configuration in the site configuration
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| i18n/it.toml | Complete Italian localization strings for the website interface |
| content/it/docs/topics/*.md | Italian translations of all topic documentation including charts, architecture, RBAC, registries, and other technical guides |
| content/it/docs/_index.md | Italian translation of the main documentation index page |
| config.toml | Configuration for Italian language support in the website |
Comments suppressed due to low confidence (1)
content/it/docs/topics/v2_v3_migration.md:1
- The article 'Un' should be 'Un'introduzione' (with apostrophe) since 'introduzione' starts with a vowel in Italian.
---
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
TerryHowe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think copilot has a couple good ideas, other than that molto bene!
TerryHowe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
TerryHowe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
I didn't notice the DCO issue. |
474b475 to
afe8f8e
Compare
I'm sorry. I've fixed the copilot suggestion because it was right and i forget to sign commit. Now it's ok! Sorry again and thanks for the review! |
TerryHowe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
Need to add ignore to |
|
After that, I think we can get this merged pretty quickly, thanks for your patience |
Hi @TerryHowe , I've done the exclusion. |
TerryHowe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Scott Rigby <[email protected]>
…notes [HIP-0024] V4 Docs content (pre-release)
[HIP-0024] Add i18n for homepage, site elements, v3 docs, blogs
Signed-off-by: Scott Rigby <[email protected]>
Signed-off-by: Nicolas Fantoni <[email protected]>
…w into feature/locate-it-helm4
hi @paigecalvert , i perform the pr #1836 into the branch. If it's ok we can close this. If you prefer that I start from main when it's merged, we can close the #1836 also and i repeat to main when it's done. |
[HIP-0024] Automate absolute links to files. Also apply all transformations to all locales
Co-authored-by: Scott Rigby <[email protected]> Signed-off-by: Paige Calvert <[email protected]>
Co-authored-by: Scott Rigby <[email protected]> Signed-off-by: Paige Calvert <[email protected]>
Co-authored-by: Scott Rigby <[email protected]> Signed-off-by: Paige Calvert <[email protected]>
Co-authored-by: Scott Rigby <[email protected]> Signed-off-by: Paige Calvert <[email protected]>
Adds two custom Netlify plugins: 1. that uses Netlify's GA caching. We are using this plugin. 2. that uses Netlify's Beta Cache API. Not using due to unreliability, but keeping for future optimization. Updated architectural decisions doc with info on this Signed-off-by: Scott Rigby <[email protected]>
Co-authored-by: Scott Rigby <[email protected]> Signed-off-by: Paige Calvert <[email protected]>
…uilds Add Netlify caching
Add info about markdown links to ARCHITECTURAL_DECISIONS
Co-authored-by: Scott Rigby <[email protected]> Signed-off-by: Paige Calvert <[email protected]>
- Resolve hero height not applying on initial page load due to React hydration timing - Fix page scrolling down on refresh when no announcement bar present - Disable browser scroll restoration on homepage to prevent jumps - Add retry mechanism to ensure styles apply after React hydration - Simplify hero height calculator and remove excessive recalculations - Set CSS min-height to prevent layout shift during load Signed-off-by: Scott Rigby <[email protected]>
Change path for v2 docs
…uild-serve [HIP-0024] Fix hero height and scroll issues on production builds
Signed-off-by: Nicolas Fantoni <[email protected]>
Signed-off-by: Nicolas Fantoni <[email protected]>
Signed-off-by: Nicolas Fantoni <[email protected]>
Signed-off-by: Nicolas Fantoni <[email protected]>
Signed-off-by: Nicolas Fantoni <[email protected]>
Signed-off-by: Nicolas Fantoni <[email protected]>
|
hi @paigecalvert , I've open new PR #1857 starting from main branch after merge new version. We can close this and work on the other for a clear situation. @karenhchu , @TerryHowe thanks for your approves in this pr |
Feature/locate it helm4
This pull request contain an italian translation for the topic section of the helm site. Let me know if something is missing or there are any errors. Thank you