Skip to content

Conversation

@nfantoni
Copy link

@nfantoni nfantoni commented Jul 9, 2024

This pull request contain an italian translation for the topic section of the helm site. Let me know if something is missing or there are any errors. Thank you

@nfantoni nfantoni changed the title Add topic in italian Translate topic section in italian language Aug 18, 2024
@nfantoni
Copy link
Author

nfantoni commented Jan 7, 2025

hi @karenhchu ,

is there something wrong with the PR that I can correct? This is my first PR and I am scared of making some errors.

Thank you

@karenhchu
Copy link
Member

@nfantoni thanks for surfacing this again and for your patience! I'll try my best to review this by EOW. Please ping me again if I don't get to it.

@nfantoni
Copy link
Author

nfantoni commented Jan 7, 2025

@karenhchu don't worry. i absolutely don't want to rush you! Thank you very much for your reply!

Copy link
Member

@karenhchu karenhchu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! There are a few pages that need to be updated but otherwise, it's in a great state. Please tag me when you've made the suggested changes and I'll take a look again.

@nfantoni
Copy link
Author

Hi @karenhchu ! Thanks for the review! I think i solved every things. the plugin page was updated after my pr and is not aligned. I hope now is ok. Let me now if need other!

Copy link
Member

@karenhchu karenhchu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We may need another approval since the PR is so large -- @scottrigby is this something you can take a look at?

@nfantoni
Copy link
Author

LGTM. We may need another approval since the PR is so large -- @scottrigby is this something you can take a look at?

I'm sorry. I promise the next ones will be smaller

@scottrigby
Copy link
Member

Hey apologies for missing this. I will review after the Helm 4 pre-release freeze in August ⏳

@TerryHowe TerryHowe requested a review from Copilot September 9, 2025 13:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a comprehensive Italian translation for the Helm website's topic section. The translation covers all major documentation areas including charts, architecture, advanced features, and various technical guides.

  • Complete translation of the Italian localization file (i18n/it.toml) with 223 entries
  • Translation of all topic documentation files from English to Italian
  • Addition of Italian language configuration in the site configuration

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 4 comments.

File Description
i18n/it.toml Complete Italian localization strings for the website interface
content/it/docs/topics/*.md Italian translations of all topic documentation including charts, architecture, RBAC, registries, and other technical guides
content/it/docs/_index.md Italian translation of the main documentation index page
config.toml Configuration for Italian language support in the website
Comments suppressed due to low confidence (1)

content/it/docs/topics/v2_v3_migration.md:1

  • The article 'Un' should be 'Un'introduzione' (with apostrophe) since 'introduzione' starts with a vowel in Italian.
---

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think copilot has a couple good ideas, other than that molto bene!

Copy link
Contributor

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TerryHowe
Copy link
Contributor

I didn't notice the DCO issue.

Commit sha: [474b475](https://github.com/helm/helm-www/pull/1602/commits/474b47570de110d235deb038604a12e51a319d8a), Author: Nicolas Fantoni, Committer: Nicolas Fantoni; The sign-off is missing.

@nfantoni
Copy link
Author

nfantoni commented Sep 9, 2025

I didn't notice the DCO issue.

Commit sha: [474b475](https://github.com/helm/helm-www/pull/1602/commits/474b47570de110d235deb038604a12e51a319d8a), Author: Nicolas Fantoni, Committer: Nicolas Fantoni; The sign-off is missing.

I'm sorry. I've fixed the copilot suggestion because it was right and i forget to sign commit. Now it's ok! Sorry again and thanks for the review!

Copy link
Contributor

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TerryHowe
Copy link
Contributor

Need to add ignore to .typos.toml

@TerryHowe
Copy link
Contributor

After that, I think we can get this merged pretty quickly, thanks for your patience

@nfantoni
Copy link
Author

  • netlify/helm-merge/deploy-preview

Hi @TerryHowe , I've done the exclusion.

Copy link
Contributor

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

scottrigby and others added 4 commits October 19, 2025 11:54
@nfantoni
Copy link
Author

Hi @nfantoni , thanks very much for your work on this.
Would you be willing to re-open this PR against the hip-0024-helm4-site-upgrade feature branch?
For context, we are moving the Helm docs site over to a new framework called Docusaurus, where i18n/translations are handled a bit differently than they were with Hugo. This means that the changes you propose in this PR won't work in the new framework (for example, Docusaurus uses different json files for translating site elements instead of toml).
So, if you're up for it, could you follow the steps in https://github.com/paigecalvert/helm-www/blob/e47e82ebcc1a75bbb011825044b9135f63a0e018/versioned_docs/version-3/community/localization.md to add the it locale? It'll be similar content-wise; mainly just the implementation details that differ. Note that you'll need to run yarn or npm install first. For an example, you can see this recent PR to initialize polish localization: #1818

Hi @paigecalvert ,
you prefer that i open the pr versus that branch and fix the difference or that i open a new branch, add content and then open the pr?

Totally up to you @nfantoni , whatever is easier. Here's the link to update the base branch of a PR, or making a new one is also fine

I'll also actually throw out one more option, which is that you can wait until next week to make these changes. We are planning to merge the hip-0024-helm4-site-upgrade feature branch on early next week (hopefully Monday or Tuesday), which will update the site to use Docusaurus. At that point, since main will be updated to docusaurus, this PR could just be refactored and then merged to main.

hi @paigecalvert ,

i perform the pr #1836 into the branch. If it's ok we can close this. If you prefer that I start from main when it's merged, we can close the #1836 also and i repeat to main when it's done.

scottrigby and others added 22 commits October 26, 2025 14:36
[HIP-0024] Automate absolute links to files. Also apply all transformations to all locales
Co-authored-by: Scott Rigby <[email protected]>
Signed-off-by: Paige Calvert <[email protected]>
Co-authored-by: Scott Rigby <[email protected]>
Signed-off-by: Paige Calvert <[email protected]>
Co-authored-by: Scott Rigby <[email protected]>
Signed-off-by: Paige Calvert <[email protected]>
Co-authored-by: Scott Rigby <[email protected]>
Signed-off-by: Paige Calvert <[email protected]>
Adds two custom Netlify plugins:
1. that uses Netlify's GA caching. We are using this plugin.
2. that uses Netlify's Beta Cache API. Not using due to unreliability, but keeping for future optimization.

Updated architectural decisions doc with info on this

Signed-off-by: Scott Rigby <[email protected]>
Co-authored-by: Scott Rigby <[email protected]>
Signed-off-by: Paige Calvert <[email protected]>
Add info about markdown links to ARCHITECTURAL_DECISIONS
Co-authored-by: Scott Rigby <[email protected]>
Signed-off-by: Paige Calvert <[email protected]>
- Resolve hero height not applying on initial page load due to React hydration timing
- Fix page scrolling down on refresh when no announcement bar present
- Disable browser scroll restoration on homepage to prevent jumps
- Add retry mechanism to ensure styles apply after React hydration
- Simplify hero height calculator and remove excessive recalculations
- Set CSS min-height to prevent layout shift during load

Signed-off-by: Scott Rigby <[email protected]>
…uild-serve

[HIP-0024] Fix hero height and scroll issues on production builds
Signed-off-by: Nicolas Fantoni <[email protected]>
Signed-off-by: Nicolas Fantoni <[email protected]>
Signed-off-by: Nicolas Fantoni <[email protected]>
Signed-off-by: Nicolas Fantoni <[email protected]>
Signed-off-by: Nicolas Fantoni <[email protected]>
@nfantoni
Copy link
Author

nfantoni commented Oct 30, 2025

hi @paigecalvert , I've open new PR #1857 starting from main branch after merge new version. We can close this and work on the other for a clear situation.

@karenhchu , @TerryHowe thanks for your approves in this pr

@nfantoni nfantoni closed this Oct 30, 2025
@nfantoni nfantoni deleted the feature/topic-it branch November 3, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.