-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate topic section in italian language #1602
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Nicolas Fantoni <[email protected]>
Signed-off-by: Nicolas Fantoni <[email protected]>
Signed-off-by: Nicolas Fantoni <[email protected]>
Signed-off-by: Andrew Block <[email protected]> Signed-off-by: Nicolas Fantoni <[email protected]>
Signed-off-by: Andrew Block <[email protected]> Signed-off-by: Nicolas Fantoni <[email protected]>
updating publishing date Signed-off-by: Karen Chu <[email protected]> Signed-off-by: Nicolas Fantoni <[email protected]>
* Docs: Fix typo on the values files page Signed-off-by: Paul Muriel Biya-Bi <[email protected]> * Docs: Add omitted word on the values files page Signed-off-by: Paul Muriel Biya-Bi <[email protected]> --------- Signed-off-by: Paul Muriel Biya-Bi <[email protected]> Signed-off-by: Nicolas Fantoni <[email protected]>
Signed-off-by: Martin Hickey <[email protected]> Signed-off-by: Nicolas Fantoni <[email protected]>
Signed-off-by: Martin Hickey <[email protected]> Signed-off-by: Nicolas Fantoni <[email protected]>
Signed-off-by: Nicolas Fantoni <[email protected]>
9a01804
to
a83b12f
Compare
Signed-off-by: Nicolas Fantoni <[email protected]>
hi @karenhchu , is there something wrong with the PR that I can correct? This is my first PR and I am scared of making some errors. Thank you |
@nfantoni thanks for surfacing this again and for your patience! I'll try my best to review this by EOW. Please ping me again if I don't get to it. |
@karenhchu don't worry. i absolutely don't want to rush you! Thank you very much for your reply! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! There are a few pages that need to be updated but otherwise, it's in a great state. Please tag me when you've made the suggested changes and I'll take a look again.
Co-authored-by: Karen Chu <[email protected]> Signed-off-by: Nicolas Fantoni <[email protected]>
Co-authored-by: Karen Chu <[email protected]> Signed-off-by: Nicolas Fantoni <[email protected]>
Co-authored-by: Karen Chu <[email protected]> Signed-off-by: Nicolas Fantoni <[email protected]>
Co-authored-by: Karen Chu <[email protected]> Signed-off-by: Nicolas Fantoni <[email protected]>
Co-authored-by: Karen Chu <[email protected]> Signed-off-by: Nicolas Fantoni <[email protected]>
Co-authored-by: Karen Chu <[email protected]> Signed-off-by: Nicolas Fantoni <[email protected]>
Co-authored-by: Karen Chu <[email protected]> Signed-off-by: Nicolas Fantoni <[email protected]>
Signed-off-by: Nicolas Fantoni <[email protected]>
Signed-off-by: Nicolas Fantoni <[email protected]>
Signed-off-by: Nicolas Fantoni <[email protected]>
Co-authored-by: Karen Chu <[email protected]> Signed-off-by: Nicolas Fantoni <[email protected]>
Signed-off-by: Nicolas Fantoni <[email protected]>
Co-authored-by: Karen Chu <[email protected]> Signed-off-by: Nicolas Fantoni <[email protected]>
Signed-off-by: Nicolas Fantoni <[email protected]>
Co-authored-by: Karen Chu <[email protected]> Signed-off-by: Nicolas Fantoni <[email protected]>
Co-authored-by: Karen Chu <[email protected]> Signed-off-by: Nicolas Fantoni <[email protected]>
Co-authored-by: Karen Chu <[email protected]> Signed-off-by: Nicolas Fantoni <[email protected]>
Co-authored-by: Karen Chu <[email protected]> Signed-off-by: Nicolas Fantoni <[email protected]>
Signed-off-by: Nicolas Fantoni <[email protected]>
Signed-off-by: Nicolas Fantoni <[email protected]>
Co-authored-by: Karen Chu <[email protected]> Signed-off-by: Nicolas Fantoni <[email protected]>
Co-authored-by: Karen Chu <[email protected]> Signed-off-by: Nicolas Fantoni <[email protected]>
Co-authored-by: Karen Chu <[email protected]> Signed-off-by: Nicolas Fantoni <[email protected]>
Signed-off-by: Nicolas Fantoni <[email protected]>
Signed-off-by: Nicolas Fantoni <[email protected]>
Signed-off-by: Nicolas Fantoni <[email protected]>
Hi @karenhchu ! Thanks for the review! I think i solved every things. the plugin page was updated after my pr and is not aligned. I hope now is ok. Let me now if need other! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We may need another approval since the PR is so large -- @scottrigby is this something you can take a look at?
This pull request contain an italian translation for the topic section of the helm site. Let me know if something is missing or there are any errors. Thank you