Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate in french all the doc #1610

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Translate in french all the doc #1610

wants to merge 15 commits into from

Conversation

BenjaminFourmaux
Copy link
Contributor

@BenjaminFourmaux BenjaminFourmaux commented Aug 1, 2024 •
edited
Loading

Translate in french categories :

  • chart_best_pratices
  • chart_template_guide
  • community
  • faq
  • howto
  • topics

@BenjaminFourmaux
Translate Best Pratices un french
4559c17 
Signed-off-by: BenjaminFourmaux <[email protected]>
@BenjaminFourmaux
Translate part 'How-to' in french
226010d 
Signed-off-by: Benjamin Fourmaux <[email protected]>
@BenjaminFourmaux
Translate topics in french
7a1dc40 
Signed-off-by: BenjaminFourmaux <[email protected]>
@BenjaminFourmaux BenjaminFourmaux marked this pull request as draft September 21, 2024 15:22
@BenjaminFourmaux BenjaminFourmaux changed the title Translate Best Pratices in french Translate in french the rest of doc Sep 21, 2024
@BenjaminFourmaux BenjaminFourmaux changed the title Translate in french the rest of doc Translate in french all the doc Sep 27, 2024
@BenjaminFourmaux
Fixing wrong hash
f606ab7 
Signed-off-by: BenjaminFourmaux <[email protected]>
@BenjaminFourmaux
Fixing wrong hash
6c656e4 
Signed-off-by: BenjaminFourmaux <[email protected]>
@BenjaminFourmaux BenjaminFourmaux marked this pull request as ready for review September 27, 2024 23:44
@BenjaminFourmaux
Typing fault
4dd5116 
Signed-off-by: Benjamin Fourmaux <[email protected]>
@TerryHowe
Copy link
Contributor

could use a translation label

@karenhchu
Copy link
Member

working on this -- will try to get to finish my review by EOW

karenhchu
karenhchu approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@karenhchu karenhchu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. Would you mind addressing the comments? Other than that, LGTM!

content/fr/docs/chart_template_guide/accessing_files.md Outdated Show resolved Hide resolved
content/fr/docs/chart_template_guide/control_structures.md Show resolved Hide resolved
content/fr/docs/chart_template_guide/control_structures.md Show resolved Hide resolved
content/fr/docs/chart_template_guide/named_templates.md Outdated Show resolved Hide resolved
content/fr/docs/chart_template_guide/variables.md Outdated Show resolved Hide resolved
content/fr/docs/topics/plugins.md Show resolved Hide resolved
content/fr/docs/topics/plugins.md Outdated Show resolved Hide resolved
content/fr/docs/topics/plugins.md Show resolved Hide resolved
content/fr/docs/topics/plugins.md Show resolved Hide resolved
content/fr/docs/topics/version_skew.md Show resolved Hide resolved
BenjaminFourmaux and others added 2 commits January 26, 2025 22:08
@BenjaminFourmaux @karenhchu
Apply suggestions from code review
be319e3 
Co-authored-by: Karen Chu <[email protected]>
Signed-off-by: Benjamin Fourmaux <[email protected]>
@BenjaminFourmaux
Changes from request review
d0efcca 
Signed-off-by: Benjamin Fourmaux <[email protected]>
@BenjaminFourmaux
Copy link
Contributor Author

Thank you for your review, I made all the requested changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karenhchu karenhchu karenhchu approved these changes

Assignees
No one assigned
Labels
docs size/XXL translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenjaminFourmaux @TerryHowe @karenhchu