update makefile and node packages #1712
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xc0derx
commented
Mar 29, 2025
xc0derx
commented
- update Makefile (add help command and set help as default command)
- update hugo to 0.145
- update node packages
- Add VSCode workspace settings and recommended extensions
xc0derx
force-pushed
the
feat-update_makefile_and_node_packages
branch
2 times, most recently
from
acd04bc to
1d0234d
Compare
Signed-off-by: Anton Shilin <[email protected]> Signed-off-by: Anton Shilin <[email protected]>
Signed-off-by: Anton Shilin <[email protected]> Signed-off-by: Anton Shilin <[email protected]>
Signed-off-by: Anton Shilin <[email protected]> Signed-off-by: Anton Shilin <[email protected]>
Signed-off-by: Anton Shilin <[email protected]> Signed-off-by: Anton Shilin <[email protected]>
Signed-off-by: Anton Shilin <[email protected]>
xc0derx
force-pushed
the
feat-update_makefile_and_node_packages
branch
from
719af9a to
674939a
Compare
Signed-off-by: Anton Shilin <[email protected]>
TerryHowe
reviewed
Apr 5, 2025
Comment on lines
31
to
+33
|
|
||
| make check-links-ci | ||
| # Uncomment the line below if you want to run link checking as part of preview | ||
| # make check-links-ci |
There was a problem hiding this comment.
Maybe just delete all this as check-links-ci doesn't seem to work with these options.
Comment on lines
+1
to
+9
| ifeq ($(UNAME),Darwin) | ||
| SHELL := /opt/local/bin/bash | ||
| OS_X := true | ||
| else ifneq (,$(wildcard /etc/redhat-release)) | ||
| OS_RHEL := true | ||
| else | ||
| OS_DEB := true | ||
| SHELL := /bin/bash | ||
| endif |
There was a problem hiding this comment.
This wasn't required under Darwin and other projects with make help I've worked on didn't bother with this or just set SHELL := /bin/bash
| OS_DEB := true | ||
| SHELL := /bin/bash | ||
| endif | ||
| .DEFAULT_GOAL := help |
There was a problem hiding this comment.
Suggested change
| .DEFAULT_GOAL := help |
First goal is the default goal, so this to me is redundant.
| SHELL := /bin/bash | ||
| endif | ||
| .DEFAULT_GOAL := help | ||
| MAKEFLAGS := --jobs=1 |
There was a problem hiding this comment.
What is the reason for setting this flag?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.