Skip to content

Conversation

@Andygol
Copy link
Contributor

@Andygol Andygol commented Nov 24, 2025

Changed SITE_URL and BASE_URL to use conditional assignment to allow sitemap.xml to use proper domain name.

Right now https://helm.sh/sitemap.xml looks like this

This XML file does not appear to have any style information associated with it. The document tree is shown below.
<urlset>
<url>
<loc>http://localhost:3000/blog</loc>
<changefreq>weekly</changefreq>
<priority>0.5</priority>
</url>
<url>
<loc>
http://localhost:3000/blog/2019/10/22/helm-2150-released
</loc>
<changefreq>weekly</changefreq>
<priority>0.5</priority>
</url>
…
<url>
<loc>http://localhost:3000/</loc>
<changefreq>weekly</changefreq>
<priority>0.5</priority>
</url>
</urlset>

This ☝️ prevents search engines from indexing the site.

@TerryHowe
Copy link
Contributor

The preview with your change still has localhost https://deploy-preview-1954--helm-merge.netlify.app/sitemap.xml

@Andygol
Copy link
Contributor Author

Andygol commented Nov 25, 2025

I made similar changes in my own branch and deployed them on netlify and got this https://andygol-helm.netlify.app/sitemap.xml

Copy link
Contributor

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TerryHowe TerryHowe merged commit 2fd8970 into helm:main Nov 25, 2025
3 checks passed
@TerryHowe
Copy link
Contributor

Looks better now, thanks!!

@Andygol Andygol deleted the patch-1 branch November 26, 2025 07:23
@Andygol
Copy link
Contributor Author

Andygol commented Nov 26, 2025

I hope this PR solved Issue #1913

@scottrigby
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants