Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support enforcement that the transitive dependency chain is there. #1884

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

justinabrahms
Copy link

Fixes #1883

I could use a bit of help with the tests. Is there a tool to generate them?

❯ ../../../../../helmfile -f helmfile.yaml template --include-needs --enforce-needs-are-installed
WARNING: release empty2 needs empty1, but empty1 is not installed due to installed: false. Either mark empty1 as installed or remove empty1 from empty2's needs
Building dependency release=empty2, chart=empty
in ./helmfile.yaml: Release empty2 has a transitive dependency empty1 marked as install=false

helmfile in ☸ tools-eks (productivity-team) in test-cases/missing-needs/input on  main [!?] via ⎈ v3.16.2 on ☁️  (us-east-1)
❯ ../../../../../helmfile -f helmfile.yaml template --include-needs
WARNING: release empty2 needs empty1, but empty1 is not installed due to installed: false. Either mark empty1 as installed or remove empty1 from empty2's needs
Building dependency release=empty2, chart=empty
WARNING: release empty2 needs empty1, but empty1 is not installed due to installed: false. Either mark empty1 as installed or remove empty1 from empty2's needs
Templating release=empty2, chart=empty
---
# Source: empty1/templates/serviceaccount.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
  name: test

@yxxhero
Copy link
Member

yxxhero commented Jan 22, 2025

@justinabrahms please fix ci issue.

@yxxhero
Copy link
Member

yxxhero commented Jan 27, 2025

@justinabrahms did you run the test case?

@justinabrahms
Copy link
Author

I ran the linter which now passes. Hadn't gotten to the tests yet. Was hoping you might answer my question about test case generation.

@yxxhero
Copy link
Member

yxxhero commented Jan 27, 2025

@justinabrahms could you see the test/integration/run.sh?
we generate the content manually now.

@yxxhero
Copy link
Member

yxxhero commented Jan 27, 2025

@justinabrahms you can try to do that. please feel free to ping me if you need any help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants