Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement polar decomposition #1697

Open
wants to merge 47 commits into
base: main
Choose a base branch
from
Open

Implement polar decomposition #1697

wants to merge 47 commits into from

Conversation

mrfh92
Copy link
Collaborator

@mrfh92 mrfh92 commented Oct 28, 2024 •
edited
Loading

Due Diligence

  • General:
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • benchmarks: created for new functionality
    • benchmarks: performance improved or maintained
    • documentation updated where needed

Description

Issue/s resolved: #

Changes proposed:

see #1696

Type of change

Memory requirements

Performance

Does this change modify the behaviour of other functions? If so, which?

yes / no

@mrfh92 mrfh92 added ESAPCA relevant for the ESA-funded project "ESAPCA" linalg enhancement New feature or request labels Oct 28, 2024
@mrfh92 mrfh92 marked this pull request as ready for review October 31, 2024 10:04
@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@codecov Codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.73134% with 21 lines in your changes missing coverage. Please review.

Project coverage is 92.24%. Comparing base (64ea1c6) to head (6b08970).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
heat/core/communication.py 17.64% 14 Missing ⚠️
heat/core/linalg/pd.py 96.27% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1697      +/-   ##
==========================================
- Coverage   92.24%   92.24%   -0.01%     
==========================================
  Files          84       85       +1     
  Lines       12460    12728     +268     
==========================================
+ Hits        11494    11741     +247     
- Misses        966      987      +21
Flag Coverage Δ
unit 92.24% <93.73%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@ClaudiaComito ClaudiaComito added this to the 1.6 milestone Nov 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@mrfh92
Copy link
Collaborator Author

mrfh92 commented Nov 15, 2024

batched QR must be merged first #1720

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@JuanPedroGHM JuanPedroGHM marked this pull request as draft January 13, 2025 09:11
@mrfh92 mrfh92 marked this pull request as ready for review January 13, 2025 09:11
@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@mrfh92 mrfh92 removed the PR talk label Jan 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@mrfh92
Copy link
Collaborator Author

mrfh92 commented Feb 10, 2025

should be merged after #1765

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mrfh92 mrfh92

Labels
benchmark PR benchmarking core enhancement New feature or request ESAPCA relevant for the ESA-funded project "ESAPCA" features linalg testing Implementation of tests, or test-related issues
Projects
Roadmap
Status: In Progress
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
3 participants
@mrfh92 @JuanPedroGHM @ClaudiaComito