Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug-fixes for DMD #1788

Closed
wants to merge 13 commits into from
Closed

Bug-fixes for DMD #1788

wants to merge 13 commits into from

Conversation

mrfh92
Copy link
Collaborator

@mrfh92 mrfh92 commented Feb 10, 2025

During benchmarking the DMD functionality, I found some minor issues and corrected them

  • the try/except construction in TS-SVD is necessary as PyTorch does not do this on its own
  • the other bug was just a typo

@github-actions github-actions bot added backport release bug Something isn't working core linalg testing Implementation of tests, or test-related issues decomposition labels Feb 10, 2025
Copy link
Contributor

Thank you for the PR!

2 similar comments
Copy link
Contributor

Thank you for the PR!

Copy link
Contributor

Thank you for the PR!

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 92.18%. Comparing base (1b1397e) to head (b1b2260).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
heat/core/linalg/svd.py 16.66% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1788      +/-   ##
==========================================
- Coverage   92.26%   92.18%   -0.08%     
==========================================
  Files          84       84              
  Lines       12447    12458      +11     
==========================================
+ Hits        11484    11485       +1     
- Misses        963      973      +10     
Flag Coverage Δ
unit 92.18% <16.66%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrfh92 mrfh92 marked this pull request as draft February 14, 2025 14:45
@mrfh92
Copy link
Collaborator Author

mrfh92 commented Feb 14, 2025

bug fix will be part of DMDc anyway

@mrfh92 mrfh92 closed this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release bug Something isn't working core decomposition linalg testing Implementation of tests, or test-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant