Skip to content

Add basic sanity checks to DNDarray#2137

Draft
brownbaerchen wants to merge 3 commits intohelmholtz-analytics:mainfrom
brownbaerchen:DNDarray_sanity_checks
Draft

Add basic sanity checks to DNDarray#2137
brownbaerchen wants to merge 3 commits intohelmholtz-analytics:mainfrom
brownbaerchen:DNDarray_sanity_checks

Conversation

@brownbaerchen
Copy link
Collaborator

@brownbaerchen brownbaerchen commented Feb 20, 2026

Description

In this PR, the following checks are implemented when instantiating a DNDarray:

  • The dimension of the resulting global array is larger or equal to the dimension of the local array
  • If the dimensions match, the shape of the global array is at least as large as the shape of the local arrays in all dimensions
  • The heat version of the type of the local data is the type of the global array

Sadly, we have quite a few tests that fail this...

My intention for this PR is a continuous check if we made progress on this. That is to say when we have fixed some of these issues, we merge main and see if we have fixed some tests. Or otherwise, we can see if we broke some more tests.
When eventually all tests pass with this PR, it can be merged.

Issue/s resolved: #

Changes proposed:

  • Basic sanity checks when instantiating a DNDarray-

Type of change

  • Points out existing bugs
  • Breaks some functions that have these bugs

@github-project-automation github-project-automation bot moved this to Todo in Roadmap Feb 20, 2026
@brownbaerchen brownbaerchen added the bug Something isn't working label Feb 20, 2026
@brownbaerchen brownbaerchen force-pushed the DNDarray_sanity_checks branch from 94bb947 to 694f496 Compare March 2, 2026 08:09
@ClaudiaComito ClaudiaComito added this to the 1.9.0 milestone Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants