Add basic sanity checks to DNDarray#2137
Draft
brownbaerchen wants to merge 3 commits intohelmholtz-analytics:mainfrom
Draft
Add basic sanity checks to DNDarray#2137brownbaerchen wants to merge 3 commits intohelmholtz-analytics:mainfrom
brownbaerchen wants to merge 3 commits intohelmholtz-analytics:mainfrom
Conversation
This was referenced Feb 20, 2026
94bb947 to
694f496
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR, the following checks are implemented when instantiating a DNDarray:
Sadly, we have quite a few tests that fail this...
My intention for this PR is a continuous check if we made progress on this. That is to say when we have fixed some of these issues, we merge main and see if we have fixed some tests. Or otherwise, we can see if we broke some more tests.
When eventually all tests pass with this PR, it can be merged.
Issue/s resolved: #
Changes proposed:
Type of change