feat(frontend): slice 1 — foundation + OKH design catalog (typed clie…#202
Closed
touchthesun wants to merge 1 commit into
Closed
feat(frontend): slice 1 — foundation + OKH design catalog (typed clie…#202touchthesun wants to merge 1 commit into
touchthesun wants to merge 1 commit into
Conversation
…nt, state primitives) First vertical slice of the v1 frontend (PRD #184, slice #197), establishing the patterns every later slice copies: - Typed API client (module 1): openapi-fetch over the generated OpenAPI types (src/api/ohm/*). Path/param/envelope are type-checked against the real contract; items narrowed to the OkhManifest view type. fetch() is resolved per-call so test interceptors (MSW) are honored. - State primitives (module 6): shadcn-based LoadingState / EmptyState / ErrorState with role=status / role=alert, component-tested. - OKH design catalog list rebuilt on the typed client + primitives, preserving search / sort / pagination and the renderable-item filter; explicit loading / empty / error states. Tests: unit (typed OKH wrapper via MSW — happy path, query params, ApiError), component (state primitives), mocked-lane E2E (browse / empty / error) + real-api lane (route loads against live API) + /okh screenshot. `make frontend-ready` green; real-api lane green against the live backend. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First vertical slice of the v1 frontend (PRD #184, slice #197), establishing the patterns every later slice copies:
Tests: unit (typed OKH wrapper via MSW — happy path, query params, ApiError), component (state primitives), mocked-lane E2E (browse / empty / error) + real-api lane (route loads against live API) + /okh screenshot.
make frontend-readygreen; real-api lane green against the live backend.