Fix default button color on Android when in dark mode, allow buttonColor to take non-hex values #871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderweasel
had a problem deploying
to
e2e Android
GitHub Actions
Error
thunderweasel
changed the title
thunderweasel
changed the title
thunderweasel
had a problem deploying
to
e2e Android
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when passing a theme of 'dark', the title changes to white, but the buttons do not. Also, buttonColor requires a hex value to be passed and not for example the hsl format. This PR changes buttonColor to have the same niceties as e.g. dividerColor, allowing various color formats and changing to white by default when the theme is dark.