refactor: use Commander.js .conflicts() for mutually exclusive options#446
Merged
refactor: use Commander.js .conflicts() for mutually exclusive options#446
Conversation
Replace manual if/error/throw validation blocks with declarative
.conflicts() declarations on Option objects. This catches conflicts at
parse time (before action handlers run) and removes 11 manual checks
across 8 command files.
Migrated conflicts:
- --quiet/--json/--verbose/--schema (status, list, branch show, repo list, log)
- --rebase/--merge (pull)
- --soft/--mixed/--hard (reset)
- --repo/--workspace (template add)
Kept as manual checks (custom error messages with actionable hints):
- --dirty/--where ("Use --where dirty,... instead")
- --no-status/filters ("Status gathering is required")
- Option-vs-argument conflicts (Commander can't express these)
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace manual if/error/throw validation blocks with declarative
.conflicts() declarations on Option objects. This catches conflicts at
parse time (before action handlers run) and removes 11 manual checks
across 8 command files.
Migrated conflicts:
Kept as manual checks (custom error messages with actionable hints):
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com