Skip to content

Bump AdvancedSharpAdbClient from 3.4.14 to 3.5.15 #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henrikwidlund merged 2 commits into from
Dec 8, 2025
Merged

Bump AdvancedSharpAdbClient from 3.4.14 to 3.5.15 #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32e25f0
Bump AdvancedSharpAdbClient from 3.4.14 to 3.5.15
dependabot[bot] Dec 8, 2025
f12737e
Fix compiler errors
henrikwidlund Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/UnfoldedCircle.AdbTv/AdbTv/AdbTvClientFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
private static readonly TimeSpan CacheDuration = TimeSpan.FromMinutes(1);
private static readonly TimeSpan HealthyDeviceTimeout = TimeSpan.FromSeconds(5);

public async ValueTask<DeviceClient?> TryGetOrCreateClientAsync(AdbTvClientKey adbTvClientKey, CancellationToken cancellationToken)

Check warning on line 25 in src/UnfoldedCircle.AdbTv/AdbTv/AdbTvClientFactory.cs

View workflow job for this annotation

GitHub Actions / Build and analyze 

Refactor this method to reduce its Cognitive Complexity from 21 to the 15 allowed. (https://rules.sonarsource.com/csharp/RSPEC-3776)

Check warning on line 25 in src/UnfoldedCircle.AdbTv/AdbTv/AdbTvClientFactory.cs

View workflow job for this annotation

GitHub Actions / Build and analyze 

Refactor this method to reduce its Cognitive Complexity from 21 to the 15 allowed. (https://rules.sonarsource.com/csharp/RSPEC-3776)
{
try
{
Expand Down Expand Up @@ -83,8 +83,8 @@
{
var deviceData = (await adbClient.GetDevicesAsync(cancellationToken)).FirstOrDefault(x =>
x.Serial.Equals(serial, StringComparison.InvariantCulture));
deviceClient = deviceData.CreateDeviceClient();
if (deviceClient.Device.State == DeviceState.Online || !RetryStates.Contains(deviceClient.Device.State))
deviceClient = deviceData?.CreateDeviceClient();
if (deviceClient is { Device.State: DeviceState.Online } || deviceClient is not null && !RetryStates.Contains(deviceClient.Device.State))
break;

await Task.Delay(100, cancellationToken);
Expand Down
2 changes: 1 addition & 1 deletion src/UnfoldedCircle.AdbTv/UnfoldedCircle.AdbTv.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="AdvancedSharpAdbClient" Version="3.4.14" />
<PackageReference Include="AdvancedSharpAdbClient" Version="3.5.15" />
<PackageReference Include="Meziantou.Analyzer" Version="2.0.257">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
Expand Down
Loading