-
-
Notifications
You must be signed in to change notification settings - Fork 597
feat: add tag supports #1514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add tag supports #1514
Conversation
|
I like this idea and the implementaion a lot but maybe there should be a way to add them at the agent level? Maybe a alternative "agent tags" system? |
I thought about that as well, but then we would need to store them in environment variables and send them to the hub. That feels like unnecessary data to transmit. Managing them would also be more difficult, since you’d have to update the variables on the agent each time. The approach I chose felt simpler to me, but I may have misunderstood what you meant. |
|
@svenvg93 Thank you so much for this i was looking for this feature (i am now using your fork), some suggestions if you find them useful:
|
|
Hi @reneManqueros, Thanks for the feedback!
We already show them on the system page, or did you mean somewhere else?
Thats a good idea and look into it! Maybe in an separate PR to keep the reviewing simple.
Thats a good idea and look into it! Maybe in an separate PR to keep the reviewing simple.
There is an option to filter based on tags |
My bad, i missed a file when merging branches, all good now, thanks |
# Conflicts: # internal/site/src/components/routes/system.tsx

This PR introduces a comprehensive tagging for systems, giving users greater flexibility in how they organize and view their systems.
Features
closes #856
closes #481
closes #447
closes #87
closes #333
closes #1055
closes #1397
closes #1559
closes #1595