Skip to content

Conversation

@JaimeRZP
Copy link
Contributor

Adds more metadata to the maps' fields used to compute the Jacknife covariance matrix.
The history of the branch seems linked to my previous PR??

@ntessore
Copy link
Contributor

Try git checkout more_metadata && git rebase --onto main FootprintFilter more_metadata && git push -f?

@JaimeRZP
Copy link
Contributor Author

Try git checkout more_metadata && git rebase --onto main FootprintFilter more_metadata && git push -f?

Nice git arcane magic!

@ntessore ntessore changed the title More metadata gh-212: metadata for bias computation Nov 23, 2024
@ntessore ntessore linked an issue Nov 23, 2024 that may be closed by this pull request
Copy link
Contributor

@ntessore ntessore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Weights class doesn't have the extra metadata yet. We should also

  1. figure out better names for the metadata, particularly variance, which isn't the variance;
  2. figure out whether to store density and effective density separately.

Let's discuss offline.

Copy link
Contributor

@ntessore ntessore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work 🎉

@ntessore ntessore merged commit 9fda271 into main Nov 27, 2024
6 checks passed
@ntessore ntessore deleted the more_metadata branch November 27, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Late computation of bias values

3 participants