Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This was referenced Jun 30, 2026
There was a problem hiding this comment.
Pull request overview
This PR addresses #201 by making mapper spin handling explicit: Mapper.transform() (and map_values()) now accept a spin argument, and heracles.mapping.transform() passes the spin from each Field instead of relying on input-array dtype metadata.
Changes:
- Add
spinparameters to theMapperprotocol and mapper implementations (healpy,ducc), and thread spin through mapping/field call sites. - Update HEALPix transform tests to pass explicit
spin. - Pass
Field.spinintomap_values()during catalog mapping.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_healpy.py | Updates HEALPix transform tests to pass explicit spin. |
| heracles/mapping.py | Passes Field.spin into mapper.transform(...) when transforming mapped data to alms. |
| heracles/mapper.py | Extends the Mapper protocol API with spin parameters for map_values() and transform(). |
| heracles/healpy.py | Updates HealpixMapper.transform() signature and removes spin inference from dtype metadata. |
| heracles/fields.py | Threads Field.spin into mapper.map_values(...) calls. |
| heracles/ducc.py | Updates DiscreteMapper.map_values() / transform() signatures to accept explicit spin. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #201