Prototype of multi-agents module for nix-darwin - #586
Conversation
b83ba41 to
4ea7a7c
Compare
aciceri
left a comment
aciceri
left a comment
There was a problem hiding this comment.
I don't have much experience with nix on mac but everything looks perfectly reasonable. Moreover I can confirm it seems to work.
|
|
||
| nix.settings.trusted-users = [ cfg.user ]; | ||
|
|
||
| system.activationScripts.preActivation.text = '' |
There was a problem hiding this comment.
I would suggest to use a different name that refers to hercules-ci for the activation script.
There was a problem hiding this comment.
preActivation is a proper name for nix-darwin (it have set of predefined names, which later substituted, I can't use arbitrary name -- https://github.com/LnL7/nix-darwin/blob/master/modules/system/activation-scripts.nix#L53 )
There was a problem hiding this comment.
Interesting...I didn't know. Their types is types.lines so they merge well if someone else sets preActivation (which was my main concern).
There was a problem hiding this comment.
Resolve it if all ok. I rebased/squashed commits
|
Replaced by #609 |
2 participants
This effort is a bit incomplete, due lack of mac osx experience and nix-darwin knowledge.
All agents by default run from same user (I have no idea how to generate uids for each agent, as well as have no idea about
knowUsersstatements and underscored names). But also here a "handle" to assign explicit user to each agent.Some path is hardcoded (common base directory), as well as usernames.
Both criticizing and advices are welcomed