Conversation
This commit makes the first incremental step toward replacing inline-c with the Nix C API by changing the Store type to wrap a C API Store pointer instead of a C++ ref<Store>. Changes: - Store now wraps Ptr CAPI.Store instead of Ptr (Ref NixStore) - openStore and withStoreFromURI now use nix_store_open from C API - Delete instance uses nix_store_free - All inline-c code dereferences through C API Store to access C++ Store - Added C API internals header to access Store::ptr field - Created nix_store typedef to disambiguate from C++ nix::Store - Updated Context to map nix_store type name to CAPI.Store - Qualified all C++ Store and StorePath references in inline-c blocks The C API Store struct wraps a nix::ref<nix::Store> in its ptr field, which we dereference in inline-c code using: $(nix_store* store)->ptr
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
TODO
hs-bindgento emit no TH (see branch)ReceiveInterrupts _;hs-bindgenavailable in NixpkgsTH trouble: