[WIP][gen] Remove locally-order-before in baseline configuration file.#1665
Draft
ShaleXIONG wants to merge 18 commits intoherd:masterfrom
Draft
[WIP][gen] Remove locally-order-before in baseline configuration file.#1665ShaleXIONG wants to merge 18 commits intoherd:masterfrom
ShaleXIONG wants to merge 18 commits intoherd:masterfrom
Conversation
ShaleXIONG
force-pushed
the
config-remove-local-order-before-dependency
branch
5 times, most recently
from
21ddcfc to
1ea6512
Compare
ShaleXIONG
force-pushed
the
config-remove-local-order-before-dependency
branch
2 times, most recently
from
4de268e to
8185218
Compare
ShaleXIONG
changed the title
ShaleXIONG
force-pushed
the
config-remove-local-order-before-dependency
branch
from
8185218 to
137bc91
Compare
ShaleXIONG
force-pushed
the
config-remove-local-order-before-dependency
branch
from
137bc91 to
86f56d6
Compare
ShaleXIONG
force-pushed
the
config-remove-local-order-before-dependency
branch
from
5ebe6d2 to
369e881
Compare
ShaleXIONG
force-pushed
the
config-remove-local-order-before-dependency
branch
from
369e881 to
42864ae
Compare
Replace the old `LexUtil` split-based relax parser with a proper lexer/parser pipeline that builds `Ast.t`. This adds support for: - top-level and grouped choice with `|`. For example `PosWR|DpAddrdW` means either `PosWR` or `DpAddrdW`. - optional relaxations with `?` For example `PosWR?`, means either `PosWR` or `` (empty). - canonical AST normalization plus expansion to concrete sequences Update `diy7`, `diycross7`, `diyone7`, `norm7`, `readRelax`, `logRelax`, `edge`, and `relax` to consume the new AST-based parser, and remove the old `lexUtil.mli` split API.
Add unit tests `gen/tests/test_parser.ml` and `.expected`. - tests for three parsers - tests for remove invalid relaxes.
…d both-type- communication.
…tests. For `...;po` and `...;po;[M]` in cat, we append the external communication edges `Obs` in the translation. Similarly for `po;...` and `[M];po;...`, we prefix `Obs`.
Add back `Amo.StAdd` and `Amo.LdAdd` as the representation for all other atomic operation. We also remove `[Q Amo.* ***]` as `Q` cannot apply to `Amo.*`
ShaleXIONG
force-pushed
the
config-remove-local-order-before-dependency
branch
2 times, most recently
from
523612c to
315b995
Compare
ShaleXIONG
force-pushed
the
config-remove-local-order-before-dependency
branch
from
315b995 to
f5939a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request revisits the baseline configuration file
forbidden.confgiven the feedback. The main purpose is to remove some unnecessary locally-order-before relaxation sequences when generating tests fromforbidden.conf. For those sequences, we explicitly add external communication edges. For example,DpCtrldWis strengthened to[DpCtrldW Ext]. Those strengthening corresponds to patterns...; poand...; po; [M]in suffix, andpo;...and[M]; po; ...in prefix.In separate commits, minor update:
*for different and same location.Extthat unfold toRfe,FreandCoe.[DpAddrdW PosWW] [DpAddrdR PosRW]because it will NOT combined bydiy7due to internal filter.lrsincat-relation toRfi, since previous mapping ofPosWRwill rule out cycles such asDMB.STdWW Rfe DpAddrdW RfiPA PodRRAP Fredue to internal filter.