[aslspec] fixed tick_loop_limit to match implementation#1770
Merged
Roman-Manevich merged 1 commit intomasterfrom Apr 8, 2026
Merged
[aslspec] fixed tick_loop_limit to match implementation#1770Roman-Manevich merged 1 commit intomasterfrom
Roman-Manevich merged 1 commit intomasterfrom
Conversation
Roman-Manevich
force-pushed
the
aslspec-fix
branch
from
a223fd4 to
e744f9c
Compare
Roman-Manevich
force-pushed
the
aslspec-fix
branch
from
e744f9c to
d60b5a8
Compare
HadrienRenaud
approved these changes
Apr 8, 2026
Collaborator
HadrienRenaud
left a comment
HadrienRenaud
left a comment
There was a problem hiding this comment.
LGTM, thanks @Roman-Manevich
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation of
tick_loop_limitchecked whether the decremented counter is greater or equal to 0, whereas the specification wrongfully checked for equality to 0.