[tools] AARCH-25405: Clarification οf the IC-Coherence-before and Instruction-read-ordered-before definitions#1788
[tools] AARCH-25405: Clarification οf the IC-Coherence-before and Instruction-read-ordered-before definitions#1788TiberiuBucur wants to merge 1 commit intoherd:masterfrom
Conversation
68f62ac to
7e428c5
Compare
|
Thanks for this Tiberiu. I think it would be nice to avoid the post processing step and I am wondering whether we should actually remove the macros \Variant{#1} and \NotVariant{#1} altogether. If miaou would produce a different macro for each variant we would be able to handle that specific macro in the catdefinitions.tex file correctly. We need to support:
@fsestini please chime in if you think there is a better solution. |
|
Unless there’s a particular reason for preferring post-processing the markdown, I would agree with @relokin. Moreover, having dedicated macros in |
7e428c5 to
e10b68d
Compare
…truction-read-ordered-before definitions
e10b68d to
dd59ef0
Compare
|
Thanks for your comments @relokin @fsestini. I made the change you requested, with a small tweak: unfortunately non-alphabetic characters are not supported in the name of new commands, so I transliterated the digits in letters. I converted the PR to ready to review, since the ticket has been communicated. |
| \newcommand{\ETSTwo}{FEAT\string_ETS2 is implemented} | ||
| \newcommand{\NotETSTwo}{it is not the case that FEAT\string_ETS2 is implemented} | ||
| \newcommand{\ETSThree}{FEAT\string_ETS3 is implemented} | ||
| \newcommand{\NotETSThree}{it is not the case that FEAT\string_ETS3 is implemented} |
There was a problem hiding this comment.
I'm assuming these commands should result in printing FEAT_ETS2 or similar.
I don't know to what extent the markdown/pandoc post-processing is affected, but \string_ does not seem to print an actual underscore when run through pdflatex on my local TeX Live installation. \textunderscore{}, however, does.
This changes the way
miaou7transliterates variants into LaTeX. In the case of a conjunction of multiple variants as part of a condition, each variant is now a separate\item, which is then translated into exactly one line of markdown. In addition, each variant needs to be uniquely defined incatdefinitions.tex. The genericVariant[1]andNotVariant[1]commands have been removed.