Skip to content

Upgrade to ES6 #3

Description

@FrogTheFrog

Hello,

so I've been writing types for snapdragon itself, but it is a little too complicated to write by hand. I decided to copy/rewrite (also fix some bugs along the way) js code into typescript and compile js and d.ts files. I've got some proposals/questions:

  1. Can I upgrade classes to ES6 classes? I've noticed that they are used for some snapdragon extensions. With typescript compiler I can generate both ES6 and ES5, so why not choose ES6?
  2. Can I remove legacy code from utils? Methods like pushNode and etc., which are no longer present in snapdragon-node itself?
  3. While I already know that you're not interested, it doesn't hurt to ask, but maybe you would like to use typescript :D ? It has many advantages over typescript, however it also has minor annoyances, but I still have no regrets after deciding to migrate to typescript.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions